docs(adr): promote ADR-0037 + ADR-0038 to Accepted (Phase 1 shipped)

This commit is contained in:
claude@clouddev1
2026-05-28 07:10:06 +00:00
parent c60026c7f6
commit 558cfae151
3 changed files with 31 additions and 12 deletions
@@ -2,9 +2,16 @@
## Status
Proposed (design agreed with the user 2026-05-27; pending `/runda` +
implementation). Redeems the follow-up **deferred by ADR-0033
Amendment 3**, which named this very ADR and its motivating consumer.
Accepted. Design agreed with the user (2026-05-27); the channel is
**implemented and validated end-to-end** by its motivating consumer
(ADR-0038's DSL → SQL teaching echo). The three-way `EffectiveMode`
{ `Simple`, `AdvancedPersistent`, `AdvancedOneShot` } resolves at submit
time in `App::submit` and threads through `Action::ExecuteDsl`
`runtime::spawn_dsl_dispatch`, which gates `echo::echo_for` on it
(handoff-46 commit `04c8e42` shipped the channel + first echo slice;
handoff-47 commit `90479cb` proved it carries the full Bucket A
catalogue). Redeems the follow-up **deferred by ADR-0033 Amendment 3**,
which named this very ADR and its motivating consumer.
## Context
+19 -7
View File
@@ -2,13 +2,25 @@
## Status
Proposed (design agreed with the user 2026-05-27; pending `/runda` +
implementation). **Realises ADR-0030 §10** ("The DSL → SQL teaching
bridge") — the Phase-5 echo that **ADR-0035 §12 forward-referenced** as
"a separate ADR." Builds on **ADR-0037** (the execution-time mode
side-channel that gates it) and **ADR-0035 Amendment 2** (the standard-
first dialect + `ALTER COLUMN` gap-fill that makes its DDL echoes
runnable).
Accepted. Design agreed with the user (2026-05-27); **Phase 1 (Bucket A)
implemented and verified** by round-tripping every single-statement DDL
row + `show data` + the `--all-rows` fall-throughs through the
advanced-mode walker (the §1 copy-paste contract). Phase 1 shipped in two
commits: handoff-46's `04c8e42` (channel + create-table slice; ADR-0037 +
this ADR) and handoff-47's `90479cb` (the renderer's full Bucket A
expansion — `Value → SQL-literal` + `Expr → SQL`, `add`/`drop`/`rename`/
`change column`, the four `add constraint` + two `drop constraint` forms,
`show data [where] [limit]` with PK-sourced `ORDER BY`, and the
`delete`/`update … --all-rows` fall-throughs; also fixed a contract gap
in the skeleton's create-table echo that silently dropped per-column
`DEFAULT` / `CHECK`). **Phase 2 (Bucket B — resolved-name + multi-line
echoes), Phase 3 (category-3 prose expansion), and the §4 de-emphasised
styled-runs rendering polish remain** — see §8 phasing + handoff-47 §5.
**Realises ADR-0030 §10** ("The DSL → SQL teaching bridge") — the Phase-5
echo that **ADR-0035 §12 forward-referenced** as "a separate ADR." Builds
on **ADR-0037** (the execution-time mode side-channel that gates it) and
**ADR-0035 Amendment 2** (the standard-first dialect + `ALTER COLUMN`
gap-fill that makes its DDL echoes runnable).
## Context
+2 -2
View File
File diff suppressed because one or more lines are too long