rdbms-playground

oli/rdbms-playground

Fork 0

Commit Graph

Author	SHA1	Message	Date
claude@clouddev1	1e06490572	round-5 follow-up: completion + i18n sweep Four user-reported gaps from the round-4 testing pass: 1. Empty-prompt hint reworded from "(no active hint)" to "Type a command — press Tab for options, `help` for a list" (6 snapshots updated to reflect 80-col truncation). 2. App-lifecycle commands (quit/q, help, rebuild, save/save as, new, load, export, import, mode, messages) now flow through the DSL parser: - 15 new keywords + catalog token entries - new Command::App(AppCommand) AST with 11 variants - parse-first dispatch in submit() (app commands work in both simple and advanced modes) - pre-chumsky source-slice for `export <path>` / `import <zip> [as <target>]` mirrors the replay precedent - UsageEntry registry entries so parse errors surface relevant usage templates - `mode <bad>` / `messages <bad>` use try_map for the friendly "unknown mode/messages" wording 3. DSL completion gaps: - `1:n` surfaces as a composite candidate at `add ` - --all-rows / --create-fk / --force-conversion / --dont-convert surface as new CandidateKind::Flag candidates (coloured with tok_flag in hint panel) - filter_clause .labelled() wrap removed so chumsky's expected-set surfaces the constituent options 4. Hardcoded user-facing strings migrated to catalog: - 4 parser custom errors (incl. the known "tables need at least one column" wart) - UnknownType Display now via parse.custom.unknown_type - UI panel titles + mode labels (Output / Hint / SIMPLE / ADVANCED / Advanced:) - app.rs cascade rendering (action labels + summary) - runtime --resume CLI stderr - db.rs change-column diagnostic tables (7 headers + 3 wrapper summaries + force-conversion hint) Tests: 765 → 769 passing, 0 failed, 1 ignored (same doctest as before). Clippy clean with -D warnings. Deferred: - ~25 thiserror #[error] attributes still hand-rolled (DbError, ArgsError, ArchiveError, PersistenceError, LockError). Tracked separately. - DSL/SQL relationship in advanced mode — clarified implicitly via parse-first dispatch; broader ADR amendment to follow. - Post-complete-parse completion gap (e.g. `save ` Tab can't offer `as` because `save` parses bare; same shape as `--create-fk` after a complete `add relationship`).	2026-05-13 15:58:29 +00:00
claude@clouddev1	c6cf3df6dc	Iteration 5: export / import commands Implements the `export` and `import` app-level commands per ADR-0015 §11 + ADR-0007 amendment 1. - `export [<path>]` writes a zip of project.yaml + data/ to <data-root>/YYYYMMDD-<projectname>-export-NN.zip by default, preserving the project's directory name as the single top-level folder inside the archive. - `import <zip> [as <target>]` extracts an exported zip into a new named project and switches to it. Target name is derived from the zip's top-level folder by default; on collision the destination auto-suffixes -02, -03, ... up to -99 instead of refusing (deviates from §2's refuse-on- collision rule for save/save as; recorded as an amendment to ADR-0015 §11). - Excludes playground.db and history.log from the zip. - Path-traversal protection via zip::enclosed_name + post- resolution check that the extraction path stays inside the target directory. Adds the zip = "5" dep with default-features = false + features = ["deflate"] to keep the binary-size cost modest. Test baseline: 370 passing, 0 failing, 0 skipped.	2026-05-08 08:24:45 +00:00

Author

SHA1

Message

Date

claude@clouddev1

1e06490572

round-5 follow-up: completion + i18n sweep

Four user-reported gaps from the round-4 testing pass:

1. Empty-prompt hint reworded from "(no active hint)" to
   "Type a command — press Tab for options, `help` for a
   list" (6 snapshots updated to reflect 80-col truncation).

2. App-lifecycle commands (quit/q, help, rebuild, save/save as,
   new, load, export, import, mode, messages) now flow through
   the DSL parser:
   - 15 new keywords + catalog token entries
   - new Command::App(AppCommand) AST with 11 variants
   - parse-first dispatch in submit() (app commands work in
     both simple and advanced modes)
   - pre-chumsky source-slice for `export <path>` /
     `import <zip> [as <target>]` mirrors the replay precedent
   - UsageEntry registry entries so parse errors surface
     relevant usage templates
   - `mode <bad>` / `messages <bad>` use try_map for the
     friendly "unknown mode/messages" wording

3. DSL completion gaps:
   - `1:n` surfaces as a composite candidate at `add `
   - --all-rows / --create-fk / --force-conversion /
     --dont-convert surface as new CandidateKind::Flag
     candidates (coloured with tok_flag in hint panel)
   - filter_clause .labelled() wrap removed so chumsky's
     expected-set surfaces the constituent options

4. Hardcoded user-facing strings migrated to catalog:
   - 4 parser custom errors (incl. the known "tables need at
     least one column" wart)
   - UnknownType Display now via parse.custom.unknown_type
   - UI panel titles + mode labels (Output / Hint / SIMPLE /
     ADVANCED / Advanced:)
   - app.rs cascade rendering (action labels + summary)
   - runtime --resume CLI stderr
   - db.rs change-column diagnostic tables (7 headers + 3
     wrapper summaries + force-conversion hint)

Tests: 765 → 769 passing, 0 failed, 1 ignored (same doctest
as before). Clippy clean with -D warnings.

Deferred:
- ~25 thiserror #[error] attributes still hand-rolled
  (DbError, ArgsError, ArchiveError, PersistenceError,
  LockError). Tracked separately.
- DSL/SQL relationship in advanced mode — clarified
  implicitly via parse-first dispatch; broader ADR
  amendment to follow.
- Post-complete-parse completion gap (e.g. `save ` Tab
  can't offer `as` because `save` parses bare; same shape
  as `--create-fk` after a complete `add relationship`).

2026-05-13 15:58:29 +00:00

claude@clouddev1

c6cf3df6dc

Iteration 5: export / import commands

Implements the `export` and `import` app-level commands per
ADR-0015 §11 + ADR-0007 amendment 1.

- `export [<path>]` writes a zip of project.yaml + data/ to
  <data-root>/YYYYMMDD-<projectname>-export-NN.zip by default,
  preserving the project's directory name as the single
  top-level folder inside the archive.
- `import <zip> [as <target>]` extracts an exported zip into
  a new named project and switches to it. Target name is
  derived from the zip's top-level folder by default; on
  collision the destination auto-suffixes -02, -03, ... up
  to -99 instead of refusing (deviates from §2's refuse-on-
  collision rule for save/save as; recorded as an amendment
  to ADR-0015 §11).
- Excludes playground.db and history.log from the zip.
- Path-traversal protection via zip::enclosed_name + post-
  resolution check that the extraction path stays inside
  the target directory.

Adds the zip = "5" dep with default-features = false +
features = ["deflate"] to keep the binary-size cost modest.

Test baseline: 370 passing, 0 failing, 0 skipped.

2026-05-08 08:24:45 +00:00

2 Commits