Grammar: with-pk column specs use name(type), matching add column
`create table … with pk` parsed column types as `name:type`,
while `add column` uses `name(type)`. Unify on the parens
form so column-type syntax is consistent across the DSL:
create table T with pk id(serial), name(text)
Only `COL_SPEC` changes (`:` → `( … )`); `build_create_table`
reads columns by role, so it is unaffected. The `:` that
separates table from column in `add column` / `drop column`
is unchanged. Sweeps the test suite, the typing-surface
matrix (two `after_colon` cells renamed to `after_paren`,
4 snapshots regenerated), the friendly catalog's usage
templates, ADR-0009's example, and requirements.md.
1039 passing / 0 failing / 1 ignored; clippy clean.
This commit is contained in:
@@ -109,7 +109,7 @@ fn parse_errors_use_no_engine_vocabulary() {
|
||||
// tiny-win recipe from handoff-5).
|
||||
"change column Tag in Customers: Tag (text)",
|
||||
// unknown type token.
|
||||
"create table T with pk id:varchar",
|
||||
"create table T with pk id(varchar)",
|
||||
// mutually exclusive flags on change column.
|
||||
"change column T: c (int) --force-conversion --dont-convert",
|
||||
// missing required clause.
|
||||
|
||||
Reference in New Issue
Block a user