WHERE expressions: matrix cells + predicate_tail grammar fix (ADR-0026 step 6)

Adds tests/typing_surface/where_expression.rs — 9 matrix
cells for the complex WHERE / show-data limit typing surface:
operator candidates after an operand, AND / OR after a
predicate, NOT, BETWEEN / IN bounds, and `show data`
where / limit.

Writing the cells surfaced a grammar bug. `predicate_tail`'s
`[NOT] negatable` branch started with `Optional(not)`, and an
Optional-first `Seq` always "commits" — so on an incomplete
input the walker's `Choice` returned that branch's
`Incomplete` early and discarded every sibling branch's
expected set, dropping `is` and the comparison operators from
completion after a column. Fixed by splitting it into
explicit `NOT negatable` and bare `negatable` branches — no
`predicate_tail` branch starts with an `Optional` now. The
matched terminal sequence is unchanged, so `build_expr` is
untouched.

Docs: ADR-0026 gains an "As-built notes" section recording
the option-1 builder realization, its two deviations from the
§3 sketch, and the deferral of §7 diagnostic flagging to
ADR-0027. requirements.md C5a -> [x] (steps 1-4) with the
test baseline refreshed to 1079; CLAUDE.md's deferred list
reconciled (C5a implemented; the QA1/QA2 note now points at
ADR-0028).

docs/adr/0026-complex-where-expressions.md

@@ -416,6 +416,66 @@ suite and the typing-surface matrix:
    walker.
 6. Typing-surface matrix cells for the new surface.
 
+### As-built notes (2026-05-18)
+
+Steps 1–4 are implemented and committed; step 5 (the §7
+diagnostic flagging) is deferred — see below. Realization
+choices, and where they deviate from the design sketch above:
+
+- **§3 builder — option 1 ("reconstruct in builder"),**
+  chosen with the project owner before implementation. The
+  stratified grammar is walked normally; its terminals flow
+  into the flat `MatchedPath` unchanged (driving highlight /
+  completion / the expected-set). `grammar::expr::build_expr`
+  then folds that flat terminal slice into the `Expr` — a
+  deterministic recursive descent mirroring the grammar
+  tiers, run only at submit-time dispatch, never per
+  keystroke. Two honest deviations from the §3 wording:
+  - **No `MatchedKind::Expr` variant.** `MatchedPath` stays
+    purely terminals — arguably more faithful to "MatchedPath
+    stays flat" than carrying a built `Expr` in it. The
+    `Expr` is assembled in the command `ast_builder`s
+    (`build_update` / `build_delete` / `build_show`), which
+    already reconstruct structured `Command`s from the flat
+    path; `build_expr` is the same pattern, one tier deeper.
+  - **There is a second structural pass** over the
+    expression tokens, scoped to submit-time dispatch. "No
+    second parse" is read as "no separate parser framework":
+    the walk validates and drives assistance, `build_expr`
+    is the single `ast_builder` for the fragment — the same
+    category as `build_insert`.
+- **Grammar shape.** `predicate` is factored as `operand
+  predicate_tail` (shared operand prefix), and the infix
+  `NOT` is factored in front of the `LIKE` / `BETWEEN` /
+  `IN` choice — so the walker's first-commit-wins `Choice`
+  semantics discriminate branches on a cleanly-failing first
+  token.
+- **`Subgrammar` depth.** `MAX_SUBGRAMMAR_DEPTH = 64` counts
+  active `Subgrammar` recursion frames. The stratified
+  grammar descends ~4–5 frames per parenthesis level, so the
+  effective parenthesis-nesting limit is roughly a dozen —
+  far past any hand-written filter; the cap is purely a
+  stack-overflow guard.
+- **§8 hints.** The expression's right-hand operands resolve
+  through a schema-aware `DynamicSubgrammar` (`where_rhs_
+  operand`) so the hint panel narrows to the compared
+  column's type, exactly as the pre-ADR `where col = val`
+  slot did. The operand grammar carries no validators —
+  permissive per §7.
+- **Step 5 deferred to ADR-0027.** The §7 *behaviour*
+  relaxation is done: `bind_where_literal` binds a
+  type-mismatched WHERE literal by its syntactic shape, and
+  the pre-ADR bind-time rejection is gone. The §7
+  *diagnostic flagging* — surfacing a type-mismatched
+  comparison or `= NULL` as an error-class highlight + hint
+  — is the seam with ADR-0027, which designs the walker
+  diagnostics-severity model that flagging belongs in (and
+  whose WARNING severity is defined to have "no triggers
+  until ADR-0026 is implemented"). Building the flagging as
+  a standalone mechanism first would be reworked by
+  ADR-0027; the recommendation is to implement it as the
+  first triggers of ADR-0027's model.
+
 ## See also
 
 - ADR-0009 — DSL command syntax conventions (`--` flags,

docs/requirements.md

@@ -26,12 +26,13 @@ repo is pushed).
 
 ## Test baseline
 
-After ADR-0025 (indexes): **1037 passing, 0 failing, 1
-ignored** (`cargo test` — the one ignored test is a
-long-standing `` ```ignore `` doc-test in
-`src/friendly/mod.rs`). Clippy clean with the nursery lint
-group enabled. (Earlier reference points: 1006 after ADR-0024
-+ the handoff-14 cleanup; 449 after B2/C2.)
+After ADR-0026 steps 1–4 (complex WHERE expressions):
+**1070 passing, 0 failing, 1 ignored** (`cargo test` — the
+one ignored test is a long-standing `` ```ignore `` doc-test
+in `src/friendly/mod.rs`). Clippy clean with the nursery lint
+group enabled. (Earlier reference points: 1039 after ADR-0025
+(indexes); 1006 after ADR-0024 + the handoff-14 cleanup; 449
+after B2/C2.)
 
 ---
 
@@ -157,12 +158,20 @@ group enabled. (Earlier reference points: 1006 after ADR-0024
   writes. Bulk insert, complex WHERE expressions, and SELECT
   in advanced mode are explicitly tracked separately — see
   C5a below.)*
-- [ ] **C5a** Complex WHERE expressions (AND/OR, comparison
+- [x] **C5a** Complex WHERE expressions (AND/OR, comparison
   operators, LIKE, IS NULL, IN, BETWEEN) for UPDATE/DELETE/
-  show-data filtering; also adds `where` and `limit` to
-  `show data`. Tracks the natural progression from DSL into
-  real SQL fluency that motivates the playground. Designed in
-  ADR-0026; implementation pending.
+  show-data filtering; `show data` also gains `where` and
+  `limit`.
+  *(ADR-0026 steps 1–4: the stratified expression grammar
+  reached through a new `Subgrammar` node, the recursive
+  `Expr` AST + `build_expr`, wiring into update / delete /
+  show data, and `Expr` → parameterised SQL with an implicit
+  primary-key `ORDER BY` for `limit`. Type-mismatched WHERE
+  comparisons are permissive — they run rather than being
+  rejected (§7). The §7 advisory **flagging** of type
+  mismatches / `= NULL` is the seam with ADR-0027's
+  diagnostics-severity model and is tracked there — see
+  ADR-0026 "As-built notes".)*
 
 ## SQL handling