oli/rdbms-playground
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

docs: session handoff 49 — ADR-0038 done, M4 + ADR statuses in sync

Browse Source
This commit is contained in:
claude@clouddev1
2026-05-28 12:24:07 +00:00
parent 2aab457c44
commit 63b2927f10
4 changed files with 210 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/adr/0038-dsl-to-sql-teaching-echo.md
+16 -6
View File
@@ -2,11 +2,12 @@
## Status
Accepted. Design agreed with the user (2026-05-27); **Phases 1–3
implemented and verified** by round-tripping every catalogue row
(§7 Buckets A, B, plus the §6 category-3 prose) through the
Accepted. Design agreed with the user (2026-05-27); **fully
implemented and verified** — every catalogue row (§7 Buckets A, B,
plus the §6 category-3 prose) round-trips per line through the
advanced-mode walker (the §1 copy-paste contract; §6 category 2
holds it per line). Shipped across three feature commits:
holds it per line), and the §4 de-emphasised styled-runs rendering
polish (ADR-0028) is wired. Shipped across four feature commits:
**Phase 1 — Bucket A single-statement** (handoff-46's `04c8e42`
delivered the channel + create-table slice; handoff-47's `90479cb`
expanded to the full Bucket A — `Value → SQL-literal` + `Expr → SQL`,
@@ -31,8 +32,17 @@ already surfaced via the pre-existing `client_side.auto_fill_*` /
`change column --dont-convert` **caveat** (the only Bucket A
caveat; every other category-3 line is illuminating), gated on an
advanced effective mode because it references "the line above".
**The §4 de-emphasised styled-runs rendering polish remains** — the
echo + caveat currently surface as plain `[system]` lines.
**Phase 4 styled-runs polish** (`2aab457`): the echoed SQL renders
as code — a new `OutputKind::TeachingEcho` line with a dimmed
`Executing SQL:` prefix followed by the SQL re-lexed in advanced
mode via `input_render::lex_to_runs_in_mode` for token-class
colouring (the same treatment the input echo gets); every
category-3 prose line (the new caveat plus the pre-existing
illuminating notes) renders dimmed via a new
`OutputStyleClass::Hint` styled-runs class resolving to
`theme.muted`. Scope went slightly beyond §4's "echo + caveat" to
cover the illuminating cat-3 notes too — user-confirmed, in service
of §6's "de-emphasised prose line" wording for every cat-3 line.
**Realises ADR-0030 §10** ("The DSL → SQL teaching bridge") — the
Phase-5 echo that **ADR-0035 §12 forward-referenced** as "a separate
ADR." Builds on **ADR-0037** (the execution-time mode side-channel