style: format the whole tree with cargo fmt (stock defaults, #35)
One-time, mechanical reformat — no functional changes. The tree was not rustfmt-clean (~1800 hunks across ~100 files); this brings it to stock `cargo fmt` defaults so a `cargo fmt --check` CI gate can follow. Behaviour-preserving: 2509 pass / 0 fail / 1 ignored (unchanged baseline), clippy clean. A .git-blame-ignore-revs entry follows so `git blame` skips this commit.
This commit is contained in:
+69
-42
@@ -172,7 +172,10 @@ fn constraint_lines(desc: &TableDescription) -> Vec<String> {
|
||||
/// A `detail` matching no marker renders neutral — the engine's
|
||||
/// plan vocabulary may grow (ADR-0028 §4).
|
||||
const PLAN_TAXONOMY: &[(&str, OutputStyleClass)] = &[
|
||||
("USING AUTOMATIC COVERING INDEX", OutputStyleClass::AutomaticIndex),
|
||||
(
|
||||
"USING AUTOMATIC COVERING INDEX",
|
||||
OutputStyleClass::AutomaticIndex,
|
||||
),
|
||||
("USING AUTOMATIC INDEX", OutputStyleClass::AutomaticIndex),
|
||||
("USING COVERING INDEX", OutputStyleClass::Efficient),
|
||||
("USING INTEGER PRIMARY KEY", OutputStyleClass::Efficient),
|
||||
@@ -225,8 +228,7 @@ fn render_plan_subtree(
|
||||
emitted: &mut HashSet<i64>,
|
||||
mode: Mode,
|
||||
) {
|
||||
let children: Vec<&ExplainRow> =
|
||||
rows.iter().filter(|r| r.parent == parent).collect();
|
||||
let children: Vec<&ExplainRow> = rows.iter().filter(|r| r.parent == parent).collect();
|
||||
let last_idx = children.len().saturating_sub(1);
|
||||
for (idx, row) in children.iter().enumerate() {
|
||||
if !emitted.insert(row.id) {
|
||||
@@ -235,8 +237,7 @@ fn render_plan_subtree(
|
||||
let is_last = idx == last_idx;
|
||||
let connector = if is_last { "└─ " } else { "├─ " };
|
||||
out.push(plan_node_line(prefix, connector, &row.detail, mode));
|
||||
let child_prefix =
|
||||
format!("{prefix}{}", if is_last { " " } else { "│ " });
|
||||
let child_prefix = format!("{prefix}{}", if is_last { " " } else { "│ " });
|
||||
render_plan_subtree(rows, row.id, &child_prefix, out, emitted, mode);
|
||||
}
|
||||
}
|
||||
@@ -343,13 +344,8 @@ pub fn render_diagnostic_table(
|
||||
const fn alignment_for(ty: Option<Type>) -> Alignment {
|
||||
match ty {
|
||||
Some(Type::Int | Type::Real | Type::Decimal | Type::Serial) => Alignment::Right,
|
||||
Some(Type::Text)
|
||||
| Some(Type::Bool)
|
||||
| Some(Type::Date)
|
||||
| Some(Type::DateTime)
|
||||
| Some(Type::Blob)
|
||||
| Some(Type::ShortId)
|
||||
| None => Alignment::Left,
|
||||
Some(Type::Text) | Some(Type::Bool) | Some(Type::Date) | Some(Type::DateTime)
|
||||
| Some(Type::Blob) | Some(Type::ShortId) | None => Alignment::Left,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -406,11 +402,7 @@ fn cell_width(s: &str) -> usize {
|
||||
/// Render a single bordered table given header cells, body
|
||||
/// rows, and per-column alignment. Outer frame +
|
||||
/// header-underline only.
|
||||
fn render_table(
|
||||
headers: &[String],
|
||||
body: &[Vec<String>],
|
||||
alignments: &[Alignment],
|
||||
) -> Vec<String> {
|
||||
fn render_table(headers: &[String], body: &[Vec<String>], alignments: &[Alignment]) -> Vec<String> {
|
||||
debug_assert_eq!(headers.len(), alignments.len());
|
||||
|
||||
// Compute column widths: max(header, all body cells).
|
||||
@@ -792,13 +784,12 @@ fn gutter_seg(i: usize, child_rows: &[usize], parent_rows: &[usize], w: usize) -
|
||||
}
|
||||
|
||||
// The vertical bus spans the full range of endpoint rows.
|
||||
let bounds = child_rows
|
||||
.iter()
|
||||
.chain(parent_rows)
|
||||
.copied()
|
||||
.fold(None, |acc: Option<(usize, usize)>, r| {
|
||||
let bounds = child_rows.iter().chain(parent_rows).copied().fold(
|
||||
None,
|
||||
|acc: Option<(usize, usize)>, r| {
|
||||
Some(acc.map_or((r, r), |(lo, hi)| (lo.min(r), hi.max(r))))
|
||||
});
|
||||
},
|
||||
);
|
||||
if let Some((top, bot)) = bounds
|
||||
&& i >= top
|
||||
&& i <= bot
|
||||
@@ -1138,7 +1129,10 @@ mod tests {
|
||||
assert!(out.contains("customer_id ●"), "FK marker:\n{out}");
|
||||
assert!(out.contains("id (PK) ●"), "parent endpoint marker:\n{out}");
|
||||
assert!(out.contains('▶'), "arrowhead:\n{out}");
|
||||
assert!(out.contains('n') && out.contains('1'), "cardinality:\n{out}");
|
||||
assert!(
|
||||
out.contains('n') && out.contains('1'),
|
||||
"cardinality:\n{out}"
|
||||
);
|
||||
assert!(
|
||||
out.contains("on delete cascade · on update no action"),
|
||||
"actions:\n{out}"
|
||||
@@ -1237,7 +1231,10 @@ mod tests {
|
||||
let (r_out, r_in) = blank_rels();
|
||||
let region = TableDescription {
|
||||
name: "Region".to_string(),
|
||||
columns: vec![col("country", Type::Int, true, false), col("code", Type::Int, true, false)],
|
||||
columns: vec![
|
||||
col("country", Type::Int, true, false),
|
||||
col("code", Type::Int, true, false),
|
||||
],
|
||||
outbound_relationships: r_out,
|
||||
inbound_relationships: r_in,
|
||||
indexes: Vec::new(),
|
||||
@@ -1277,7 +1274,10 @@ mod tests {
|
||||
.collect::<Vec<_>>()
|
||||
.join("\n");
|
||||
assert!(text.contains("region_code ●"), "child endpoint 2:\n{text}");
|
||||
assert!(text.contains("(PK) ●"), "parent endpoint is PK + marked:\n{text}");
|
||||
assert!(
|
||||
text.contains("(PK) ●"),
|
||||
"parent endpoint is PK + marked:\n{text}"
|
||||
);
|
||||
assert!(
|
||||
text.contains("(country, region_code) ▶ Region.(country, code)"),
|
||||
"pairing line:\n{text}",
|
||||
@@ -1412,11 +1412,7 @@ mod tests {
|
||||
let data = DataResult {
|
||||
table_name: "Customers".to_string(),
|
||||
columns: vec!["id".to_string(), "Name".to_string(), "Email".to_string()],
|
||||
column_types: vec![
|
||||
Some(Type::Serial),
|
||||
Some(Type::Text),
|
||||
Some(Type::Text),
|
||||
],
|
||||
column_types: vec![Some(Type::Serial), Some(Type::Text), Some(Type::Text)],
|
||||
rows: vec![
|
||||
vec![
|
||||
Some("1".to_string()),
|
||||
@@ -1634,7 +1630,10 @@ mod tests {
|
||||
assert!(out.contains("Indexes:"), "got:\n{out}");
|
||||
assert!(out.contains("idx_email (Email)"), "got:\n{out}");
|
||||
// A plain index carries no uniqueness marker.
|
||||
assert!(!out.contains("[unique]"), "plain index unmarked; got:\n{out}");
|
||||
assert!(
|
||||
!out.contains("[unique]"),
|
||||
"plain index unmarked; got:\n{out}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -1677,7 +1676,10 @@ mod tests {
|
||||
indexes: Vec::new(),
|
||||
unique_constraints: vec![vec!["a".to_string(), "b".to_string()]],
|
||||
check_constraints: vec![
|
||||
crate::persistence::TableCheck { name: None, expr: "a < b".to_string() },
|
||||
crate::persistence::TableCheck {
|
||||
name: None,
|
||||
expr: "a < b".to_string(),
|
||||
},
|
||||
crate::persistence::TableCheck {
|
||||
name: Some("a_lt_b".to_string()),
|
||||
expr: "a <> b".to_string(),
|
||||
@@ -1691,7 +1693,10 @@ mod tests {
|
||||
// (ADR-0035 Amendment 1) so the user can `drop constraint <name>`.
|
||||
assert!(out.contains("unique_a_b: unique (a, b)"), "got:\n{out}");
|
||||
assert!(out.contains("check (a < b)"), "unnamed check; got:\n{out}");
|
||||
assert!(out.contains("check a_lt_b (a <> b)"), "named check shows its name; got:\n{out}");
|
||||
assert!(
|
||||
out.contains("check a_lt_b (a <> b)"),
|
||||
"named check shows its name; got:\n{out}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -1732,17 +1737,37 @@ mod tests {
|
||||
let plan = QueryPlan {
|
||||
display_sql: "SELECT 1".to_string(),
|
||||
rows: vec![
|
||||
ExplainRow { id: 1, parent: 0, detail: "root".to_string() },
|
||||
ExplainRow { id: 2, parent: 1, detail: "child-a".to_string() },
|
||||
ExplainRow { id: 3, parent: 1, detail: "child-b".to_string() },
|
||||
ExplainRow {
|
||||
id: 1,
|
||||
parent: 0,
|
||||
detail: "root".to_string(),
|
||||
},
|
||||
ExplainRow {
|
||||
id: 2,
|
||||
parent: 1,
|
||||
detail: "child-a".to_string(),
|
||||
},
|
||||
ExplainRow {
|
||||
id: 3,
|
||||
parent: 1,
|
||||
detail: "child-b".to_string(),
|
||||
},
|
||||
],
|
||||
};
|
||||
let lines = render_explain_plan(&plan, Mode::Simple);
|
||||
// display SQL + 3 plan nodes.
|
||||
assert_eq!(lines.len(), 4);
|
||||
assert!(lines[1].text.contains("root"));
|
||||
assert!(lines[2].text.contains("├─ child-a"), "got {:?}", lines[2].text);
|
||||
assert!(lines[3].text.contains("└─ child-b"), "got {:?}", lines[3].text);
|
||||
assert!(
|
||||
lines[2].text.contains("├─ child-a"),
|
||||
"got {:?}",
|
||||
lines[2].text
|
||||
);
|
||||
assert!(
|
||||
lines[3].text.contains("└─ child-b"),
|
||||
"got {:?}",
|
||||
lines[3].text
|
||||
);
|
||||
// The single root uses `└─`; its children are indented
|
||||
// by three spaces (no `│` spine, the root being last).
|
||||
assert!(lines[1].text.starts_with("└─ root"));
|
||||
@@ -1775,7 +1800,10 @@ mod tests {
|
||||
fn render_explain_plan_colours_a_full_scan_expensive() {
|
||||
let plan = one_node_plan("SCAN Customers");
|
||||
let lines = render_explain_plan(&plan, Mode::Simple);
|
||||
assert_eq!(span_class_for(&lines[1], "SCAN"), OutputStyleClass::Expensive);
|
||||
assert_eq!(
|
||||
span_class_for(&lines[1], "SCAN"),
|
||||
OutputStyleClass::Expensive
|
||||
);
|
||||
// The table name stays neutral (ADR-0028 §6).
|
||||
assert_eq!(
|
||||
span_class_for(&lines[1], "Customers"),
|
||||
@@ -1801,8 +1829,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn render_explain_plan_flags_an_automatic_index() {
|
||||
let plan =
|
||||
one_node_plan("SEARCH Orders USING AUTOMATIC COVERING INDEX (CustId=?)");
|
||||
let plan = one_node_plan("SEARCH Orders USING AUTOMATIC COVERING INDEX (CustId=?)");
|
||||
let lines = render_explain_plan(&plan, Mode::Simple);
|
||||
assert_eq!(
|
||||
span_class_for(&lines[1], "USING AUTOMATIC COVERING INDEX"),
|
||||
|
||||
Reference in New Issue
Block a user