docs: record ADR-0024 completion, reconcile requirements.md + handoff-14
ADR-0024 audited as fully implemented. Amend the ADR with a "Phase F minimal" implementation note (parser.rs retained as the router + ParseError home) and update the README index line to match. Reconcile docs/requirements.md against handoffs 10-14: refresh the test baseline (449 -> 1006), mark U4 (replay) satisfied, correct the A1 / H1a / H3 progress notes. Amend handoff-14: §3 flagged items both resolved (ranker kept, CommandNode.hint_mode removed); §4 rewritten as a concrete next-work pointer at the reconciled requirements.md.
This commit is contained in:
@@ -579,6 +579,22 @@ test suite still all-green; `cargo clippy --all-targets --
|
||||
-D warnings` passes; `cargo build --release` binary not
|
||||
noticeably larger.
|
||||
|
||||
**Implementation note (2026-05-15) — "Phase F minimal".**
|
||||
Phase F shipped as planned with one deliberate deviation:
|
||||
`dsl/parser.rs` was *retained*, not deleted. The chumsky +
|
||||
lexer pipeline is gone (chumsky dependency removed; `lexer.rs`,
|
||||
`keyword.rs`, `ident_slot.rs`, `usage.rs` all deleted; the
|
||||
`parse.token.*` catalog entries collapsed), but `parser.rs`
|
||||
remains as the thin router: it owns the public `parse_command`
|
||||
/ `parse_command_with_schema` entry points and the `ParseError`
|
||||
type, whose `{message, position, at_eof, expected}` shape
|
||||
completion, hint rendering, and the input-renderer overlay all
|
||||
depend on. Deleting the file would only scatter that surface
|
||||
across `walker` / `dsl/mod.rs` for no functional gain. The
|
||||
differential scaffolding was never built as a live harness —
|
||||
it materialised as hand-curated expectation tests. `parser.rs`
|
||||
documents this in its own module doc comment.
|
||||
|
||||
### Test discipline
|
||||
|
||||
Three guarantees throughout migration:
|
||||
|
||||
+1
-1
@@ -29,4 +29,4 @@ This directory contains the project's ADRs, recorded per
|
||||
- [ADR-0021 — Parser-as-source-of-truth for H1a (per-command usage in parse errors)](0021-parser-as-source-of-truth-for-h1a.md)
|
||||
- [ADR-0022 — Ambient typing assistance: colour, hint panel, completion (I3 + I4)](0022-ambient-typing-assistance.md)
|
||||
- [ADR-0023 — Unified declarative grammar tree](0023-unified-grammar-tree.md) — direction (superseded for execution detail by ADR-0024)
|
||||
- [ADR-0024 — Unified grammar tree: execution plan](0024-unified-grammar-tree-execution-plan.md) — **Accepted**, the executable spec
|
||||
- [ADR-0024 — Unified grammar tree: execution plan](0024-unified-grammar-tree-execution-plan.md) — **Accepted**, the executable spec — implemented (Phases A–F; Phase F shipped "minimal", `parser.rs` retained as the router — see the ADR's Phase F implementation note)
|
||||
|
||||
Reference in New Issue
Block a user