separate types

js-fp3/infrastructure/repository.d.ts

@@ -0,0 +1,31 @@
+import { Result } from '../library/result.js';
+import { Account, AccountError } from '../domain/account.js';
+
+export type Repository = {
+  loadAccount: (id: string) => Result<Account, AccountError>;
+  saveAccount: (account: Account) => Result<Account, AccountError>;
+};
+
+export type AppErrorRepositoryCreationFailed = {
+  type: 'RepositoryCreationFailed';
+  message: string;
+};
+
+export type AppErrorInnerAccountError = {
+  type: 'InnerAccountError';
+  innerError: AccountError;
+};
+
+export type AppError =
+  | AppErrorRepositoryCreationFailed
+  | AppErrorInnerAccountError;
+
+export declare const repositoryCreationFailed: (
+  message: string
+) => AppErrorRepositoryCreationFailed;
+
+export declare const innerAccountError: (
+  innerError: AccountError
+) => AppErrorInnerAccountError;
+
+export declare const createInMemoryRepository: () => Repository;

js-fp3/infrastructure/repository.js

@@ -2,46 +2,19 @@ import { ok, fail } from '../library/result.js';
 import { logReturn } from '../library/logging.js';
 import { accountNotFound } from '../domain/account.js';
 
-/**
- * @typedef {Object} Repository
- * @property {(id: string) => import('../library/result.js').Result<import('../domain/account.js').Account, import('../domain/account.js').AccountError>} loadAccount
- * @property {(account: import('../domain/account.js').Account) => import('../library/result.js').Result<import('../domain/account.js').Account, import('../domain/account.js').AccountError>} saveAccount
- */
-
-/** @typedef {{ type: 'RepositoryCreationFailed', message: string }} AppErrorRepositoryCreationFailed */
-/** @typedef {{ type: 'InnerAccountError', innerError: import('../domain/account.js').AccountError }} AppErrorInnerAccountError */
-
-/** @typedef {AppErrorRepositoryCreationFailed | AppErrorInnerAccountError} AppError */
-
-/**
- * @param {string} message
- * @returns {AppErrorRepositoryCreationFailed}
- */
 export const repositoryCreationFailed = (message) => ({
   type: 'RepositoryCreationFailed',
   message,
 });
 
-/**
- * @param {import('../domain/account.js').AccountError} innerError
- * @returns {AppErrorInnerAccountError}
- */
 export const innerAccountError = (innerError) => ({
   type: 'InnerAccountError',
   innerError,
 });
 
-/**
- * @returns {Repository}
- */
 export const createInMemoryRepository = () => {
-  /** @type {Map<string, import('../domain/account.js').Account>} */
   const store = new Map();
 
-  /**
-   * @param {string} id
-   * @returns {import('../library/result.js').Result<import('../domain/account.js').Account, import('../domain/account.js').AccountError>}
-   */
   const getById = (id) =>
     store.has(id)
       ? logReturn(
@@ -53,10 +26,6 @@ export const createInMemoryRepository = () => {
           fail(accountNotFound(id))
         );
 
-  /**
-   * @param {import('../domain/account.js').Account} account
-   * @returns {import('../library/result.js').Result<import('../domain/account.js').Account, import('../domain/account.js').AccountError>}
-   */
   const save = (account) => {
     store.set(account.id, account);
     return logReturn(